Ref T8742. We are adopting PSR-2 at my work, which means that we need to be using elseif instead of else if. The rationale behind this is so that all control keywords look like single words. I was considering adding a boolean xhpast.elseif.single-token configuration option, but I'm not sure how value this would be?
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8742: Write a bunch of PSR-2 lint rules
Updated unit tests.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- xhpast-lint2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7689 Build 8415: [Placeholder Plan] Wait for 30 Seconds Build 8414: arc lint + arc unit
Event Timeline
Comment Actions
I want to stick with else if in this codebase (rationale roughly being that the grammar is better with fewer tokens, and if we could remove all the "elseif" / "endif" / "endwhile" cruft from the grammar we would; and that the other C-like languages we use -- Javascript and C -- do not support this construct, so using "else if" is more consistent across languages). Probably adding a module and then configuring this one as disabled in your codebase is the cleanest way forward?
I'm OK with bringing the alternate module upstream. I'm also OK with having a "psr-2" mode if it requires a nontrivial number of adjustments.
Comment Actions
Allow the linter rule to be configurable such that either elseif or else if can be preferred.