Ref T1049. This adds support for aborting builds in Harbormaster.
- Group Reviewers
- Maniphest Tasks
- T1049: Implement Harbormaster
- Restricted Diffusion Commit
rPd5dc4588fce4: [harbormaster/abort-builds] Support aborting builds in Harbormaster
Tested it in production.
I think we should rename "STOP" to "PAUSE", in the code and in the UI if it's still there anywhere. The difference between STOP and ABORT is not clear or obvious when reading the code.
Then I think we should consider calling this STOP, to contrast with PAUSE, although I think it's probably clear enough as ABORT.
Prefer single space after period.
and work will be discarded and builds can not be resumed and must be completely restarted
Just release the artifacts? Why are you also picking up the other restart side effects?
No reason to nest these.
Prevent abort of automatic builds, as other methods now do.