Differential D13490

[Redesign] Use status icons in Maniphest task list
ClosedPublic
Actions

Authored by chad on Jun 30 2015, 8:27 PM.

Tags

None

Referenced Files

	F14356576: D13490.id32640.diff
	Thu, Dec 19, 10:17 PM

	Unknown Object (File)
	Wed, Dec 18, 3:32 AM

	Unknown Object (File)
	Tue, Dec 17, 1:07 PM

	Unknown Object (File)
	Fri, Dec 6, 4:16 AM

	Unknown Object (File)
	Thu, Dec 5, 4:42 AM

	Unknown Object (File)
	Wed, Nov 20, 4:30 PM

	Unknown Object (File)
	Nov 15 2024, 10:44 PM

	Unknown Object (File)
	Oct 20 2024, 11:00 PM

Subscribers

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign
T8339: Allow setting of icons in maniphest.status

Commits

Restricted Diffusion Commit
rPf2f168cceb22: [Redesign] Use status icons in Maniphest task list

Summary

Ref T8099, Fixes T8339. This lets us pull in the status icon and display in lists and object headers.

Test Plan

Look at a list of open and closed tasks, see icons match state (duplicate, spite, defaults).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 32640.Jun 30 2015, 8:27 PM

chad retitled this revision from to [Redesign] Use status icons in Maniphest task list.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added tasks: T8339: Allow setting of icons in maniphest.status, T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 30 2015, 8:27 PM

btrahan accepted this revision.Jun 30 2015, 8:34 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/maniphest/view/ManiphestTaskListView.php
81	You can end up with the "grey" class twice, but that's probably okay. Otherwise, you could re-factor to something like this $color = idx($color_map, $task->getPriority(), 'grey'); if ($task->isClosed()) { $item->setDisabled(true); $color = 'grey'; } $icon .= ' '.$color;

This revision is now accepted and ready to land.Jun 30 2015, 8:34 PM

Closed by commit rPf2f168cceb22: [Redesign] Use status icons in Maniphest task list (authored by chad, committed by chad). · Explain WhyJun 30 2015, 8:42 PM

This revision was automatically updated to reflect the committed changes.

chad marked an inline comment as done.

thx

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

constants/

ManiphestTaskStatus.php

2 lines

view/

ManiphestTaskListView.php

9 lines

Diff 32641

src/applications/maniphest/constants/ManiphestTaskStatus.php

Loading...

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...