Page MenuHomePhabricator

[Redesign] Use status icons in Maniphest task list
ClosedPublic

Authored by chad on Jun 30 2015, 8:27 PM.

Details

Summary

Ref T8099, Fixes T8339. This lets us pull in the status icon and display in lists and object headers.

Test Plan

Look at a list of open and closed tasks, see icons match state (duplicate, spite, defaults).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 32640.Jun 30 2015, 8:27 PM
chad retitled this revision from to [Redesign] Use status icons in Maniphest task list.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
btrahan accepted this revision.Jun 30 2015, 8:34 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/maniphest/view/ManiphestTaskListView.php
81

You can end up with the "grey" class twice, but that's probably okay. Otherwise, you could re-factor to something like this

$color = idx($color_map, $task->getPriority(), 'grey');
if ($task->isClosed()) {
  $item->setDisabled(true);
  $color = 'grey';
}
$icon .= ' '.$color;
This revision is now accepted and ready to land.Jun 30 2015, 8:34 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.