Page MenuHomePhabricator
Differential D13484

Don't require missing fields be present in order to subscribe to an object
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 12:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 5:44 PM
Unknown Object (File)
Thu, Dec 5, 11:12 AM
Unknown Object (File)
Wed, Nov 27, 5:56 PM
Unknown Object (File)
Sun, Nov 24, 4:01 AM
Unknown Object (File)
Nov 13 2024, 11:14 PM
Unknown Object (File)
Nov 4 2024, 2:28 PM
Unknown Object (File)
Oct 28 2024, 4:26 PM
Unknown Object (File)
Oct 24 2024, 12:53 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8719: Subscribing to an object does not continue on missing fields
Commits
Restricted Diffusion Commit
rP594690ade94e: Don't require missing fields be present in order to subscribe to an object
Summary

Fixes T8719. It's fine to subscribe to objects that don't have all their required fields filled in.

Test Plan

Subscribed/unsubscribed from an object.

Diff Detail

Repository
rP Phabricator
Branch
missingfield
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7059
Build 7171: [Placeholder Plan] Wait for 30 Seconds
Build 7170: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32622.Jun 30 2015, 12:22 PM
epriestley retitled this revision from to Don't require missing fields be present in order to subscribe to an object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8719: Subscribing to an object does not continue on missing fields.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 12:22 PM
btrahan accepted this revision.Jun 30 2015, 6:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 6:13 PM
Closed by commit rP594690ade94e: Don't require missing fields be present in order to subscribe to an object (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2015, 6:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
subscriptions/
controller/
1 line

Diff 32622

View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

Loading...
Phabricator · Built by Phacility