Differential D13484

Don't require missing fields be present in order to subscribe to an object
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 12:22 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8719: Subscribing to an object does not continue on missing fields

Commits

Restricted Diffusion Commit
rP594690ade94e: Don't require missing fields be present in order to subscribe to an object

Summary

Fixes T8719. It's fine to subscribe to objects that don't have all their required fields filled in.

Test Plan

Subscribed/unsubscribed from an object.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32622.Jun 30 2015, 12:22 PM

epriestley retitled this revision from to Don't require missing fields be present in order to subscribe to an object.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8719: Subscribing to an object does not continue on missing fields.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 12:22 PM

btrahan accepted this revision.Jun 30 2015, 6:13 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2015, 6:13 PM

Closed by commit rP594690ade94e: Don't require missing fields be present in order to subscribe to an object (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2015, 6:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

subscriptions/

controller/

PhabricatorSubscriptionsEditController.php

1 line

Diff 32632

View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

Don't require missing fields be present in order to subscribe to an objectClosedPublicActions