Page MenuHomePhabricator

Cache remarkup engines in Feed
ClosedPublic

Authored by epriestley on Jun 29 2015, 10:18 PM.
Tags
None
Referenced Files
F12822144: D13480.id32616.diff
Thu, Mar 28, 7:05 AM
Unknown Object (File)
Tue, Mar 26, 12:13 PM
Unknown Object (File)
Thu, Mar 21, 10:11 PM
Unknown Object (File)
Sun, Mar 10, 9:31 PM
Unknown Object (File)
Sat, Mar 9, 6:52 PM
Unknown Object (File)
Feb 9 2024, 11:35 AM
Unknown Object (File)
Feb 9 2024, 10:39 AM
Unknown Object (File)
Feb 3 2024, 5:30 AM
Subscribers

Details

Summary

Ref T8631. This method uses cached settings.

Test Plan

Saw 40% performance improvement locally (reduced 200ms of 500ms).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Cache remarkup engines in Feed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/feed/story/PhabricatorFeedStory.php
523
This revision is now accepted and ready to land.Jun 30 2015, 6:12 PM
This revision was automatically updated to reflect the committed changes.