Differential D13480

Cache remarkup engines in Feed
ClosedPublic
Actions

Authored by epriestley on Jun 29 2015, 10:18 PM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

T8631: Straighten out the fetch plan for feed stories

Commits

Restricted Diffusion Commit
rPa8f5e10b790f: Cache remarkup engines in Feed

Summary

Ref T8631. This method uses cached settings.

Test Plan

Saw 40% performance improvement locally (reduced 200ms of 500ms).

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 32616.Jun 29 2015, 10:18 PM

epriestley retitled this revision from to Cache remarkup engines in Feed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8631: Straighten out the fetch plan for feed stories.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2015, 10:18 PM

btrahan accepted this revision.Jun 30 2015, 6:12 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/feed/story/PhabricatorFeedStory.php
523	Looks like we have this in a few more spots: https://secure.phabricator.com/diffusion/P/browse/master/?grep=PhabricatorMarkupEngine%3A%3AnewMarkupEngine

This revision is now accepted and ready to land.Jun 30 2015, 6:12 PM

Closed by commit rPa8f5e10b790f: Cache remarkup engines in Feed (authored by epriestley). · Explain WhyJun 30 2015, 6:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

story/

PhabricatorFeedStory.php

2 lines

Diff 32635

src/applications/feed/story/PhabricatorFeedStory.php

Loading...