Page MenuHomePhabricator

Cache remarkup engines in Feed
ClosedPublic

Authored by epriestley on Jun 29 2015, 10:18 PM.

Details

Summary

Ref T8631. This method uses cached settings.

Test Plan

Saw 40% performance improvement locally (reduced 200ms of 500ms).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Cache remarkup engines in Feed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Jun 30 2015, 6:12 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/feed/story/PhabricatorFeedStory.php
523
This revision is now accepted and ready to land.Jun 30 2015, 6:12 PM
This revision was automatically updated to reflect the committed changes.