Page MenuHomePhabricator
Differential D13472

Spaces + Diffusion - make creating a new repository work again
ClosedPublic
Actions

Authored by btrahan on Jun 29 2015, 6:52 PM.
Tags
None
Referenced Files
F14367499: D13472.id32600.diff
Fri, Dec 20, 3:52 PM
Unknown Object (File)
Thu, Dec 12, 1:34 AM
Unknown Object (File)
Thu, Dec 12, 1:12 AM
Unknown Object (File)
Sun, Dec 8, 5:03 PM
Unknown Object (File)
Thu, Dec 5, 3:14 PM
Unknown Object (File)
Mon, Dec 2, 11:56 PM
Unknown Object (File)
Sat, Nov 30, 9:01 PM
Unknown Object (File)
Wed, Nov 27, 3:38 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8702: PhabricatorApplicationTransactionValidationException when trying to create a new repository
Commits
Restricted Diffusion Commit
rP12b966f44e51: Spaces + Diffusion - make creating a new repository work again
Summary

Fixes T8702. Needed to teach these controls how to serialize / unserialize themselves in that they are storing two values (policy phid + space phid) nowadays

Test Plan

made a new repo successfully with policy as described in T8702. Also edited policy successfully.

Diff Detail

Repository
rP Phabricator
Branch
T8702
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7044
Build 7141: [Placeholder Plan] Wait for 30 Seconds
Build 7140: arc lint + arc unit

Event Timeline

btrahan updated this revision to Diff 32599.Jun 29 2015, 6:52 PM
btrahan added a task: T8702: PhabricatorApplicationTransactionValidationException when trying to create a new repository.
btrahan retitled this revision from to Spaces + Diffusion - make creating a new repository work again.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 29 2015, 6:52 PM
epriestley accepted this revision.Jun 29 2015, 6:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2015, 6:53 PM
Closed by commit rP12b966f44e51: Spaces + Diffusion - make creating a new repository work again (authored by btrahan, committed by btrahan). · Explain WhyJun 29 2015, 6:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
form/
control/
16 lines

Diff 32599

View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
Phabricator · Built by Phacility