Differential D13441

Carefully avoid the harbormaster/differential race
ClosedPublic
Actions

Authored by epriestley on Jun 25 2015, 4:52 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker

Commits

Restricted Diffusion Commit
rPdb1bc7fd7f1f: Carefully avoid the harbormaster/differential race

Summary

Ref T8650. This should stop the problem, but isn't a root cause fix. See discussion on the task.

Test Plan

Made some local diffs, but this is a bit hard to reproduce reliably.

Diff Detail

Repository

rP Phabricator

Branch

race1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/editor/DifferentialTransactionEditor.php:588	XHP16	TODO Comment
Advice	src/applications/harbormaster/engine/HarbormasterBuildEngine.php:426	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 7010
Build 7075: [Placeholder Plan] Wait for 30 Seconds
Build 7074: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32533.Jun 25 2015, 4:52 PM

epriestley retitled this revision from to Carefully avoid the harbormaster/differential race.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2015, 4:52 PM

btrahan accepted this revision.Jun 25 2015, 5:03 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 25 2015, 5:03 PM

Closed by commit rPdb1bc7fd7f1f: Carefully avoid the harbormaster/differential race (authored by epriestley, committed by epriestley). · Explain WhyJun 25 2015, 5:05 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D17139: Allow Harbormaster builds to publish to a different object.Jan 4 2017, 9:24 PM

epriestley mentioned this in rPef05bf335d8e: Allow Harbormaster builds to publish to a different object.Jan 4 2017, 9:46 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

4 lines

harbormaster/

engine/

HarbormasterBuildEngine.php

88 lines

Diff 32533

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php