Page MenuHomePhabricator
Differential D13419

Popup datepicker should respect user preferred week start day
ClosedPublic
Actions

Authored by lpriestley on Jun 25 2015, 12:50 AM.
Tags
None
Referenced Files
F15540202: D13419.id.diff
Fri, Apr 25, 6:46 AM
F15537439: D13419.diff
Thu, Apr 24, 1:44 PM
F15533604: D13419.id32499.diff
Wed, Apr 23, 8:45 PM
F15516777: D13419.diff
Fri, Apr 18, 9:09 PM
F15427287: D13419.id32500.diff
Mar 23 2025, 1:33 PM
F15416731: D13419.id32500.diff
Mar 20 2025, 1:13 PM
F15410223: D13419.id.diff
Mar 19 2025, 6:55 AM
F15389647: D13419.id32499.diff
Mar 15 2025, 5:31 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8605: Date Picker does not use `Week Starts On` Setting
Commits
Restricted Diffusion Commit
rP109fa940111e: Popup datepicker should respect user preferred week start day
Summary

Fixes T8605, Popup datepicker should respect user preferred week start day

Test Plan

Edit event, open datepicker, calendar weeks should start on Sunday by default, and another day, if specified in User Preferences.

Diff Detail

Repository
rP Phabricator
Branch
calendardatepickerweekstart
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6982
Build 7022: [Placeholder Plan] Wait for 30 Seconds
Build 7021: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 32498.Jun 25 2015, 12:50 AM
lpriestley retitled this revision from to Popup datepicker should respect user preferred week start day.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8605: Date Picker does not use `Week Starts On` Setting.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 25 2015, 12:50 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
lpriestley updated this revision to Diff 32499.Jun 25 2015, 12:52 AM
lpriestley edited edge metadata.

Removing unnecessary type-cast

lpriestley updated this revision to Diff 32500.Jun 25 2015, 12:54 AM

Proper camelCase

epriestley accepted this revision.Jun 27 2015, 3:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2015, 3:48 PM
Closed by commit rP109fa940111e: Popup datepicker should respect user preferred week start day (authored by lpriestley, committed by lpriestley). · Explain WhyJun 27 2015, 5:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
view/
form/
control/
5 lines
webroot/
rsrc/
js/
core/
21 lines

Diff 32498

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...
Phabricator · Built by Phacility