Page MenuHomePhabricator
Differential D13382

Smooth out some UI/UX issues in Harbormaster
ClosedPublic
Actions

Authored by epriestley on Jun 21 2015, 8:47 PM.
Tags
None
Referenced Files
F13133536: D13382.diff
Wed, May 1, 10:26 PM
Unknown Object (File)
Mon, Apr 29, 4:43 PM
Unknown Object (File)
Thu, Apr 25, 12:51 AM
Unknown Object (File)
Wed, Apr 17, 2:40 PM
Unknown Object (File)
Tue, Apr 9, 3:18 AM
Unknown Object (File)
Sat, Apr 6, 12:59 PM
Unknown Object (File)
Mar 25 2024, 1:55 PM
Unknown Object (File)
Mar 21 2024, 1:13 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8096: Improve Harbormaster UI/UX (v1)
Commits
Restricted Diffusion Commit
rPc31e25d5ceed: Smooth out some UI/UX issues in Harbormaster
Summary

Ref T8096. Fixes a few bugs and glitches.

  • Set build completion time when handling a message.
  • Format duration information in a more human-readable way.
  • Use a table for build variables.
  • Fix up container PHIDs on diffs (a touch hacky, should be OK for now though).
Test Plan

Browsed around the UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32397.Jun 21 2015, 8:47 PM
epriestley retitled this revision from to Smooth out some UI/UX issues in Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).
Herald added a subscriber: epriestley. · View Herald TranscriptJun 21 2015, 8:47 PM
btrahan accepted this revision.Jun 22 2015, 5:16 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2015, 5:16 PM
Closed by commit rPc31e25d5ceed: Smooth out some UI/UX issues in Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2015, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
15 lines
harbormaster/
controller/
102 lines
28 lines
10 lines
engine/
5 lines
worker/
6 lines

Diff 32460

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterController.php

Loading...
View Options

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterTargetWorker.php

Loading...
Phabricator · Built by Phacility