Page MenuHomePhabricator

Truncate large strings in DarkConsole
ClosedPublic

Authored by epriestley on Jun 18 2015, 7:23 PM.
Tags
None
Referenced Files
F18845745: D13347.diff
Wed, Oct 29, 2:16 PM
F18817360: D13347.id32291.diff
Tue, Oct 21, 2:56 PM
F18767816: D13347.id.diff
Wed, Oct 8, 12:26 AM
F18760408: D13347.diff
Mon, Oct 6, 9:12 AM
F18726420: D13347.diff
Tue, Sep 30, 6:37 AM
F18712596: D13347.diff
Sep 29 2025, 5:28 AM
F18498433: D13347.diff
Sep 4 2025, 6:42 PM
F18491014: D13347.id.diff
Sep 4 2025, 12:08 AM
Subscribers

Details

Summary

Ref T8597. If a page issues a large query (like inserting a blob into file storage), we may try to utf8ize the entire thing. This is slow and pointless.

Instead, truncate tab data after 4096 bytes before sanitizing.

Test Plan

Adjusted limit to 256 bytes, saw long queries get truncated reasonably.

Diff Detail

Repository
rP Phabricator
Branch
darkconsole1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6854
Build 6876: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Truncate large strings in DarkConsole.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 18 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.