Differential D13341

Drop Windows-specific escaping in preallocated host
ClosedPublic
Actions

Authored by hach-que on Jun 18 2015, 3:04 PM.

Tags

Referenced Files

	F13098687: D13341.diff
	Fri, Apr 26, 9:24 AM

	Unknown Object (File)
	Wed, Apr 24, 11:01 PM

	Unknown Object (File)
	Sun, Apr 21, 5:48 PM

	Unknown Object (File)
	Fri, Apr 12, 3:25 AM

	Unknown Object (File)
	Fri, Apr 12, 3:25 AM

	Unknown Object (File)
	Fri, Apr 12, 3:19 AM

	Unknown Object (File)
	Fri, Apr 12, 2:58 AM

	Unknown Object (File)
	Sat, Apr 6, 11:35 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP70a82017b3b9: Drop Windows-specific escaping in preallocated host

Summary

This drops the Windows-specific escaping code for the creation of directories when acquiring a lease. This is basically the change from D10378 without the other, no longer necessary changes.

Test Plan

This code hasn't been run in a production environment for a while (any instances of Phabricator using Drydock / Harbormaster with Windows have had this code removed by the D10378 patch for a while).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hach-que updated this revision to Diff 32279.Jun 18 2015, 3:04 PM

hach-que retitled this revision from to Drop Windows-specific escaping in preallocated host.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2015, 3:04 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

hach-que mentioned this in D10378: Spawn a new Powershell session when running commands on Windows.Jun 18 2015, 3:04 PM

hach-que mentioned this in D10495: [drydock/core] Use WinRM instead of SSH for Windows hosts.Jun 18 2015, 3:21 PM

hach-que edited edge metadata.Jun 18 2015, 4:11 PM

hach-que added a project: Drydock.

epriestley accepted this revision.Jun 19 2015, 12:17 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 19 2015, 12:17 AM

Closed by commit rP70a82017b3b9: Drop Windows-specific escaping in preallocated host (authored by hach-que, committed by hach-que). · Explain WhyJun 19 2015, 5:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

blueprint/

DrydockPreallocatedHostBlueprintImplementation.php

15 lines

Diff 32313

src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php

Loading...