Page MenuHomePhabricator

Run setup checks from the CLI
Needs ReviewPublic

Authored by joshuaspence on Jun 18 2015, 12:04 PM.
Tags
None
Referenced Files
F14000127: D13336.diff
Thu, Oct 24, 7:24 PM
F13978373: D13336.id32268.diff
Fri, Oct 18, 10:54 PM
F13969482: D13336.id32448.diff
Thu, Oct 17, 2:48 AM
Unknown Object (File)
Oct 2 2024, 11:18 AM
Unknown Object (File)
Sep 29 2024, 12:50 PM
Unknown Object (File)
Sep 4 2024, 12:06 PM
Unknown Object (File)
Aug 28 2024, 9:11 AM
Unknown Object (File)
Aug 26 2024, 12:21 AM
Subscribers

Details

Summary

Fixes T2383. Allows setup checks to be run from the CLI with ./bin/config check. The general idea is to split the PhabricatorSetupCheck::executeChecks method into three smaller components:

  • PhabricatorSetupCheck::executeCommandLineChecks is used for running setup checks which are specific to the command line. We don't really have any of these, but this diff makes it possible for us to add these types of checks.
  • PhabricatorSetupCheck::executeWebChecks is used for running setup checks which only make sense in a web context.
  • PhabricatorSetupCheck::executeCommonChecks is used to execute common checks shared between the command-line and web.
Test Plan

This probably needs some more work, but seeking some initial feedback.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6955
Build 6977: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Run setup checks from the CLI.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Show table borders