Fixes T8599. I'm not sure how to reproduce the original issue, but I'm fairly confident that the issue is that the issue is that execute() is not called on the query object.
- Group Reviewers
- Maniphest Tasks
- T8599: Exceptions about after extending from Phobject
- Restricted Diffusion Commit
rP7f6508af5a3d: Add missing execution on archived task query
Created a Harbormaster build plan with a single "Lease Host" step. Ran ./bin/harbormaster build --plan 1 D1 from the command line and hit the exception as described in T8599. Applied patch and hit a different exception (which I think is just because I don't know how to use Drydock and Harbormaster).
After applying this patch, I hit the following exception instead:
[2015-06-18 18:41:31] EXCEPTION: (Exception) Lease has been broken! at [<phabricator>/src/applications/drydock/storage/DrydockLease.php:172] arcanist(head=master, ref.master=9a7c4d87a850), phabricator(head=master, ref.master=5be6b3b141bc), phutil(head=master, ref.master=81eed10bea57) #0 <#2> DrydockLease::waitForLeases(array) called at [<phabricator>/src/applications/drydock/storage/DrydockLease.php:198] #1 <#2> DrydockLease::waitUntilActive() called at [<phabricator>/src/applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php:32] #2 <#2> HarbormasterLeaseHostBuildStepImplementation::execute(HarbormasterBuild, HarbormasterBuildTarget) called at [<phabricator>/src/applications/harbormaster/worker/HarbormasterTargetWorker.php:52] #3 phlog(Exception) called at [<phabricator>/src/applications/harbormaster/worker/HarbormasterTargetWorker.php:81] #4 PhabricatorWorker::scheduleTask(string, array) called at [<phabricator>/src/applications/harbormaster/engine/HarbormasterBuildEngine.php:84] #5 HarbormasterBuildEngine::continueBuild() called at [<phabricator>/src/applications/harbormaster/worker/HarbormasterBuildWorker.php:25] #6 HarbormasterBuildWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:117] #7 PhabricatorWorker::scheduleTask(string, array) called at [<phabricator>/src/applications/harbormaster/storage/HarbormasterBuildable.php:151] #8 HarbormasterBuildable::applyPlan(HarbormasterBuildPlan) called at [<phabricator>/src/applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php:87] #9 HarbormasterManagementBuildWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:406] #10 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:301] #11 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/setup/manage_harbormaster.php:21]