Page MenuHomePhabricator
Differential D13330

More correct fix - set default value array() for `getParameter` call.
ClosedPublic
Actions

Authored by lpriestley on Jun 17 2015, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:45 AM
Unknown Object (File)
Mon, Apr 29, 2:27 PM
Unknown Object (File)
Sat, Apr 27, 9:06 PM
Unknown Object (File)
Wed, Apr 24, 10:27 PM
Unknown Object (File)
Wed, Apr 10, 11:04 AM
Unknown Object (File)
Sun, Apr 7, 6:20 AM
Unknown Object (File)
Sat, Apr 6, 5:16 PM
Unknown Object (File)
Sat, Apr 6, 5:16 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8577: InvalidArgumentException when viewing upcoming calendar events
Commits
Restricted Diffusion Commit
rP9109cf62e464: More correct fix - set default value array() for `getParameter` call.
Summary

Ref T8577, More correct fix - set default value array() for getParameter call.

Test Plan

Make sure saved queries like Month View, Day View, and Upcoming Events, still work.

Diff Detail

Repository
rP Phabricator
Branch
calendartypeaheaddefault
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6829
Build 6851: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 32254.Jun 17 2015, 3:29 PM
lpriestley retitled this revision from to More correct fix - set default value array() for `getParameter` call..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8577: InvalidArgumentException when viewing upcoming calendar events.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2015, 3:29 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 18 2015, 12:32 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 18 2015, 12:32 PM
Closed by commit rP9109cf62e464: More correct fix - set default value array() for `getParameter` call. (authored by lpriestley, committed by lpriestley). · Explain WhyJun 18 2015, 4:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
8 lines

Diff 32254

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
Phabricator · Built by Phacility