Page MenuHomePhabricator
Differential D13330

More correct fix - set default value array() for `getParameter` call.
ClosedPublic
Actions

Authored by lpriestley on Jun 17 2015, 3:29 PM.
Tags
None
Referenced Files
F15537060: D13330.id.diff
Thu, Apr 24, 11:55 AM
F15527217: D13330.id32282.diff
Tue, Apr 22, 1:58 AM
F15525415: D13330.diff
Mon, Apr 21, 2:14 PM
F15485203: D13330.id32254.diff
Wed, Apr 9, 10:31 PM
F15478844: D13330.id32282.diff
Tue, Apr 8, 3:15 AM
F15476903: D13330.id.diff
Mon, Apr 7, 10:02 AM
F15475155: D13330.diff
Sun, Apr 6, 4:37 PM
F15439321: D13330.id32254.diff
Wed, Mar 26, 6:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8577: InvalidArgumentException when viewing upcoming calendar events
Commits
Restricted Diffusion Commit
rP9109cf62e464: More correct fix - set default value array() for `getParameter` call.
Summary

Ref T8577, More correct fix - set default value array() for getParameter call.

Test Plan

Make sure saved queries like Month View, Day View, and Upcoming Events, still work.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 32254.Jun 17 2015, 3:29 PM
lpriestley retitled this revision from to More correct fix - set default value array() for `getParameter` call..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8577: InvalidArgumentException when viewing upcoming calendar events.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2015, 3:29 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 18 2015, 12:32 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 18 2015, 12:32 PM
Closed by commit rP9109cf62e464: More correct fix - set default value array() for `getParameter` call. (authored by lpriestley, committed by lpriestley). · Explain WhyJun 18 2015, 4:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
8 lines

Diff 32282

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
Phabricator · Built by Phacility