Differential D13326

Only evaluate tokens if phids not null
ClosedPublic
Actions

Authored by lpriestley on Jun 17 2015, 7:06 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8577: InvalidArgumentException when viewing upcoming calendar events

Commits

Restricted Diffusion Commit
rP868ee3ef2fd1: Only evaluate tokens if phids not null

Summary

Fixes T8577, Only evaluate tokens if phids not null

Test Plan

Open Upcoming Events in Calendar.

Diff Detail

Repository

rP Phabricator

Branch

calendartypeaheaderror

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6825
Build 6847: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 32244.Jun 17 2015, 7:06 AM

lpriestley retitled this revision from to Only evaluate tokens if phids not null.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8577: InvalidArgumentException when viewing upcoming calendar events.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2015, 7:06 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 17 2015, 12:00 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 17 2015, 12:00 PM

Closed by commit rP868ee3ef2fd1: Only evaluate tokens if phids not null (authored by lpriestley, committed by lpriestley). · Explain WhyJun 17 2015, 3:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventSearchEngine.php

4 lines

Diff 32244

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Only evaluate tokens if phids not nullClosedPublicActions