Differential D13306

[Redesign] Move to light header by default
ClosedPublic
Actions

Authored by chad on Jun 16 2015, 4:27 PM.

Tags

None

Referenced Files

	F14642442: D13306.diff
	Sat, Jan 11, 5:59 AM

	Unknown Object (File)
	Tue, Dec 31, 12:58 AM

	Unknown Object (File)
	Thu, Dec 26, 5:25 AM

	Unknown Object (File)
	Sat, Dec 14, 3:59 PM

	Unknown Object (File)
	Dec 8 2024, 8:09 PM

	Unknown Object (File)
	Dec 7 2024, 12:28 AM

	Unknown Object (File)
	Dec 4 2024, 11:57 PM

	Unknown Object (File)
	Nov 29 2024, 3:09 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP69b30c5d538b: [Redesign] Move to light header by default

Summary

This should default to light, also made the icons on the dark headers more transparent.

Test Plan

Tested light, dark, blue, blindigo, and default.

Diff Detail

Repository

Branch

main-header

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6803
Build 6825: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,867 ms	PhabricatorLibraryTestCase::testMethodVisibility
	3 ms	CelerityResourceTransformerTestCase::testTransformation
	204 ms	PhabricatorCelerityTestCase::testCelerityMaps
	11 ms	PhabricatorConduitTestCase::testConduitMethods
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled
		View Full Test Results (1 Failed · 7 Passed)

Event Timeline

chad updated this revision to Diff 32200.Jun 16 2015, 4:27 PM

chad retitled this revision from to [Redesign] Move to light header by default.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2015, 4:27 PM

epriestley accepted this revision.Jun 16 2015, 4:42 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2015, 4:42 PM

I'll just pull these until I get the all clear on your internet.

Closed by commit rP69b30c5d538b: [Redesign] Move to light header by default (authored by chad, committed by epriestley). · Explain WhyJun 16 2015, 4:42 PM

This revision was automatically updated to reflect the committed changes.

I'm 7 days away from reasonable Internet. I'm sipping by on 100 mb a day.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

16 lines

src/

applications/

celerity/

CelerityResourceTransformer.php

2 lines

config/

option/

PhabricatorUIConfigOptions.php

2 lines

Diff 32200

resources/celerity/map.php

Loading...

src/applications/celerity/CelerityResourceTransformer.php

Loading...

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...