Ref T4558. If a Diviner atom is a ghost (i.e. the underlying source code has been removed), mark it as closed in the search index.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4558: Make Diviner useful for third-parties
- Commits
- Restricted Diffusion Commit
rPa3010148e24d: Mark diviner atoms as closed in search index
Searched for a ghost atom in global searcn and saw the results show "Closed".
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/diviner/search/DivinerAtomSearchIndexer.php | ||
|---|---|---|
| 38 | Technically I think this is meant to be PhabricatorTime::getNow()? | |
Comment Actions
Yeah, I think there's a task somewhere. Eventually we should swap 'em all, but it could cause issues right now since getNow() may be frozen (for unit tests) but that could hang loops like this:
while (time() < $start + 5) { ... }But PhabricatorTime::getNow() is slightly preferable in cases where it's OK if "now" is frozen by a unit test.