Page MenuHomePhabricator

Mark diviner atoms as closed in search index
ClosedPublic

Authored by joshuaspence on Jun 15 2015, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 2:37 PM
Unknown Object (File)
Tue, Mar 12, 3:52 AM
Unknown Object (File)
Tue, Mar 12, 3:52 AM
Unknown Object (File)
Tue, Mar 12, 3:52 AM
Unknown Object (File)
Tue, Mar 12, 3:52 AM
Unknown Object (File)
Mon, Mar 4, 11:34 AM
Unknown Object (File)
Feb 7 2024, 4:13 PM
Unknown Object (File)
Feb 3 2024, 5:03 AM
Subscribers

Details

Summary

Ref T4558. If a Diviner atom is a ghost (i.e. the underlying source code has been removed), mark it as closed in the search index.

Test Plan

Searched for a ghost atom in global searcn and saw the results show "Closed".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Mark diviner atoms as closed in search index.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2015, 1:13 PM
src/applications/diviner/search/DivinerAtomSearchIndexer.php
38

Technically I think this is meant to be PhabricatorTime::getNow()?

Should I change time() to PhabricatorTime::getNow()?

Yeah, I think there's a task somewhere. Eventually we should swap 'em all, but it could cause issues right now since getNow() may be frozen (for unit tests) but that could hang loops like this:

while (time() < $start + 5) { ... }

But PhabricatorTime::getNow() is slightly preferable in cases where it's OK if "now" is frozen by a unit test.

joshuaspence edited edge metadata.

Change time() to PhabricatorTime::getNow()

This revision was automatically updated to reflect the committed changes.