Page MenuHomePhabricator
Differential D13293

Fix a few more undeclared properties
ClosedPublic
Actions

Authored by joshuaspence on Jun 15 2015, 8:58 AM.
Tags
None
Referenced Files
F18498400: D13293.diff
Thu, Sep 4, 6:40 PM
F18443329: D13293.diff
Sun, Aug 31, 6:53 PM
F18377176: D13293.id.diff
Thu, Aug 28, 12:12 PM
F18366313: D13293.diff
Wed, Aug 27, 10:10 PM
F18365193: D13293.diff
Wed, Aug 27, 8:35 PM
F18362412: D13293.diff
Wed, Aug 27, 1:48 PM
F18349476: D13293.id32152.diff
Tue, Aug 26, 6:19 PM
F18303533: D13293.id32154.diff
Sat, Aug 23, 9:50 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
benoittgt
de_jean_7777
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8541: Domain Exception on trying to write to undefined property mailer
T8538: Phd daemon won't run
T8539: arc diff - create return Undefined class constant 'TYPE_SPACE'
Commits
Restricted Diffusion Commit
rP62648237c25e: Fix a few more undeclared properties
Summary

Ref T8538. Ref T8539. Ref T8541.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32152.Jun 15 2015, 8:58 AM
joshuaspence retitled this revision from to Fix a few more undeclared properties.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added tasks: T8539: arc diff - create return Undefined class constant 'TYPE_SPACE', T8538: Phd daemon won't run .
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 15 2015, 8:58 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence added a reviewer: de_jean_7777.Jun 15 2015, 9:08 AM
benoittgt accepted this revision.Jun 15 2015, 9:14 AM
benoittgt added a reviewer: benoittgt.
joshuaspence updated this revision to Diff 32153.Jun 15 2015, 9:21 AM
joshuaspence edited edge metadata.

Fix DiffusionPathChangeQuery

josetesan added a task: T8541: Domain Exception on trying to write to undefined property mailer.Jun 15 2015, 9:37 AM
joshuaspence updated this object.EditedJun 15 2015, 9:38 AM
joshuaspence edited the test plan for this revision. (Show Details)

@epriestley, going to Cowboy Commits this... If there's any more major issues then I'll just revert the original change.

Closed by commit rP62648237c25e: Fix a few more undeclared properties (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 15 2015, 9:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
pathid/
2 lines
feed/
builder/
1 line
herald/
adapter/
1 line
metamta/
adapter/
2 lines
releeph/
view/
branch/
5 lines

Diff 32154

View Options

src/applications/diffusion/query/pathid/DiffusionPathIDQuery.php

Loading...
View Options

src/applications/feed/builder/PhabricatorFeedBuilder.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerLiteAdapter.php

Loading...
View Options

src/applications/releeph/view/branch/ReleephBranchTemplate.php

Loading...
Phabricator · Built by Phacility