Page MenuHomePhabricator
Differential D13291

Date controls should respect user time preferences
ClosedPublic
Actions

Authored by lpriestley on Jun 15 2015, 5:32 AM.
Tags
None
Referenced Files
F13187077: D13291.diff
Sat, May 11, 4:19 AM
F13184582: D13291.id32173.diff
Fri, May 10, 8:35 PM
F13177660: D13291.diff
Wed, May 8, 7:52 PM
Unknown Object (File)
Mon, Apr 29, 4:34 PM
Unknown Object (File)
Mon, Apr 29, 3:12 PM
Unknown Object (File)
Thu, Apr 25, 12:34 AM
Unknown Object (File)
Wed, Apr 24, 9:44 AM
Unknown Object (File)
Mon, Apr 22, 1:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8362: Set date time account preferences
Commits
Restricted Diffusion Commit
rP86a908d3b9ed: Date controls should respect user time preferences
Summary

Ref T8362, Date controls should respect user time preferences

Test Plan

Set user time preference to 24-hour format, create an event, type 23 in time input, 23:00 should be suggested. Saveing a 24-hour format time should save correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 32138.Jun 15 2015, 5:32 AM
lpriestley retitled this revision from to Date controls should respect user time preferences.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8362: Set date time account preferences.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 15 2015, 5:32 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
lpriestley updated this revision to Diff 32139.Jun 15 2015, 5:33 AM
lpriestley edited edge metadata.

commented out

epriestley accepted this revision.Jun 15 2015, 1:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2015, 1:28 PM
Closed by commit rP86a908d3b9ed: Date controls should respect user time preferences (authored by lpriestley, committed by lpriestley). · Explain WhyJun 15 2015, 5:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
form/
control/
32 lines
80 lines
webroot/
rsrc/
js/
core/
73 lines

Diff 32173

View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
View Options

webroot/rsrc/js/core/behavior-time-typeahead.js

Loading...
Phabricator · Built by Phacility