Page MenuHomePhabricator
Differential D13265

Mark some PhabricatorApplication methods as final
ClosedPublic
Actions

Authored by joshuaspence on Jun 13 2015, 12:36 AM.
Tags
None
Referenced Files
F15404402: D13265.id32062.diff
Tue, Mar 18, 7:34 AM
F15389673: D13265.id32062.diff
Sat, Mar 15, 5:33 AM
F15387741: D13265.id32114.diff
Sat, Mar 15, 2:50 AM
Unknown Object (File)
Feb 11 2025, 9:29 PM
Unknown Object (File)
Feb 3 2025, 4:05 PM
Unknown Object (File)
Jan 29 2025, 7:42 PM
Unknown Object (File)
Jan 29 2025, 3:40 PM
Unknown Object (File)
Jan 29 2025, 11:16 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP934285a6d3d2: Mark some PhabricatorApplication methods as final
Summary

I don't believe that any subclass should override these methods.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32062.Jun 13 2015, 12:36 AM
joshuaspence retitled this revision from to Mark some PhabricatorApplication methods as final.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2015, 12:36 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 13 2015, 3:52 PM
epriestley edited edge metadata.

I think it's plausible that a couple of these (like getApplicationURI() and isInstalled()) might eventually have some kind of use case, but we can add hooks or strip final if/when they do. Most of them seem unambiguously final.

This revision is now accepted and ready to land.Jun 13 2015, 3:52 PM
joshuaspence updated this revision to Diff 32112.Jun 14 2015, 9:26 PM
joshuaspence edited edge metadata.

Rebase

Closed by commit rP934285a6d3d2: Mark some PhabricatorApplication methods as final (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 14 2015, 9:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
36 lines

Diff 32114

View Options

src/applications/base/PhabricatorApplication.php

Loading...
Phabricator · Built by Phacility