Page MenuHomePhabricator

Mark some PhabricatorApplication methods as final
ClosedPublic

Authored by joshuaspence on Jun 13 2015, 12:36 AM.
Tags
None
Referenced Files
F18823013: D13265.id.diff
Thu, Oct 23, 9:50 AM
F18817591: D13265.diff
Tue, Oct 21, 4:46 PM
F18682218: D13265.diff
Fri, Sep 26, 5:23 AM
F18672543: D13265.id32062.diff
Sep 25 2025, 7:43 AM
F18672497: D13265.id32112.diff
Sep 25 2025, 7:37 AM
F18672479: D13265.id32114.diff
Sep 25 2025, 7:35 AM
F18596368: D13265.diff
Sep 13 2025, 12:31 AM
F18034085: D13265.id32062.diff
Aug 3 2025, 1:02 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP934285a6d3d2: Mark some PhabricatorApplication methods as final
Summary

I don't believe that any subclass should override these methods.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Mark some PhabricatorApplication methods as final.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I think it's plausible that a couple of these (like getApplicationURI() and isInstalled()) might eventually have some kind of use case, but we can add hooks or strip final if/when they do. Most of them seem unambiguously final.

This revision is now accepted and ready to land.Jun 13 2015, 3:52 PM
This revision was automatically updated to reflect the committed changes.