Paths

Table of Contentst

Differential D13233

Garbage collect old notifications
ClosedPublic
Actions

Authored by joshuaspence on Jun 10 2015, 12:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 1:54 AM

	Unknown Object (File)
	Mon, Apr 15, 1:52 AM

	Unknown Object (File)
	Thu, Apr 11, 9:33 AM

	Unknown Object (File)
	Mon, Apr 8, 2:59 PM

	Unknown Object (File)
	Mon, Apr 1, 10:08 AM

	Unknown Object (File)
	Mar 21 2024, 5:00 PM

	Unknown Object (File)
	Mar 21 2024, 5:00 PM

	Unknown Object (File)
	Mar 18 2024, 5:09 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8473: Garbage collect old notifications

Commits

Restricted Diffusion Commit
rP5a00b5f6f62e: Garbage collect old notifications

Summary

Fixes T8473. Adds garbage collection to the phabricator_feed.feed_storynotification table.

Test Plan

Reduced the TTL to a really small value and ran the trigger daemon. Saw feed notifications removed from the database.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31987.Jun 10 2015, 12:16 PM

joshuaspence retitled this revision from to Garbage collect old notifications.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8473: Garbage collect old notifications.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 10 2015, 12:16 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Let's just hard-code this TTL as 90 days. I want to get rid of the gcdaemon.ttl.* config since I think it's some of the least useful config we have, and I believe almost no one ever adjusts it.

(If someone comes up with some amazing use case, we could move the options to the Daemons application and have PhabricatorGarbageCollector classes automatically populate them.)

This revision is now accepted and ready to land.Jun 10 2015, 12:28 PM

Remove config

Closed by commit rP5a00b5f6f62e: Garbage collect old notifications (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 10 2015, 8:55 PM

This revision was automatically updated to reflect the committed changes.

Pawka mentioned this in T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.Sep 10 2015, 7:52 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

notification/

garbagecollector/

FeedStoryNotificationGarbageCollector.php

22 lines

storage/

PhabricatorFeedStoryNotification.php

3 lines

Diff 32000

src/__phutil_library_map__.php

Loading...

src/applications/notification/garbagecollector/FeedStoryNotificationGarbageCollector.php

Loading...

src/applications/notification/storage/PhabricatorFeedStoryNotification.php

Loading...