Page MenuHomePhabricator

Apply Herald subscription effects immediately
ClosedPublic

Authored by epriestley on Jun 8 2015, 1:51 PM.

Details

Summary

Fixes T8464. We could incorrectly use a cached value when computing CC's.

Just load a fresh value. There are no other callers that would benefit from this cache, so it's more complicated to reload it correctly prior to publishing than to just skip it.

Also make the PHID headers unique.

Test Plan
  • Verified that users received mail about the transactions which caused them to be added to an object.
  • Veirfied that headers no longer have redundant values.

Diff Detail

Repository
rP Phabricator
Branch
hcc9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6624
Build 6646: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Apply Herald subscription effects immediately.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 5:47 PM
This revision was automatically updated to reflect the committed changes.