Page MenuHomePhabricator

Mark some strings for translation
ClosedPublic

Authored by joshuaspence on Jun 8 2015, 8:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 2:32 PM
Unknown Object (File)
Thu, Feb 20, 8:51 AM
Unknown Object (File)
Sat, Feb 15, 7:26 AM
Unknown Object (File)
Tue, Feb 11, 9:25 PM
Unknown Object (File)
Sat, Feb 8, 7:50 AM
Unknown Object (File)
Sat, Feb 8, 7:49 AM
Unknown Object (File)
Sat, Feb 8, 7:49 AM
Unknown Object (File)
Sat, Feb 8, 7:48 AM
Subscribers

Details

Summary

Add some more phtizations.

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Mark some strings for translation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
src/error/PhutilErrorHandler.php
423–425 ↗(On Diff #31901)

Possibly pht might not be defined at this point I suspect? If so, we could do something like this:

if (function_exists('pht')) {
  $err_str = pht(
    'Error handler was reentered, some errors were not passed to the '.
    'listener.');
} else {
  $err_str = 
    'Error handler was reentered, some errors were not passed to the '.
    'listener.';
}

error_log($err_str);
epriestley edited edge metadata.
epriestley added inline comments.
src/error/PhutilErrorHandler.php
423–425 ↗(On Diff #31901)

I don't think we should translate this, because of the potential to recurse indefinitely if the error is in pht() itself.

That seems worse/more dangerous than a Spanish developer getting one English error message after already hitting a double-bad error.

This revision is now accepted and ready to land.Jun 8 2015, 8:56 PM
joshuaspence edited edge metadata.

Remove changes to PhutilErrorHandler

This revision was automatically updated to reflect the committed changes.