Page MenuHomePhabricator

Mark some strings for translation
ClosedPublic

Authored by joshuaspence on Jun 8 2015, 8:16 AM.
Tags
None
Referenced Files
F19811504: D13199.diff
Wed, Mar 4, 1:23 AM
F19661527: D13199.id31901.diff
Feb 7 2026, 7:11 AM
F19601698: D13199.id31901.diff
Feb 3 2026, 5:14 AM
F19562316: D13199.diff
Jan 31 2026, 12:26 PM
F19531307: D13199.id.diff
Jan 20 2026, 3:56 AM
F19527722: D13199.id.diff
Jan 19 2026, 3:55 AM
F19219662: D13199.diff
Dec 17 2025, 10:27 AM
F18704596: D13199.diff
Sep 28 2025, 8:15 AM
Subscribers

Details

Summary

Add some more phtizations.

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Mark some strings for translation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
src/error/PhutilErrorHandler.php
423–425 ↗(On Diff #31901)

Possibly pht might not be defined at this point I suspect? If so, we could do something like this:

if (function_exists('pht')) {
  $err_str = pht(
    'Error handler was reentered, some errors were not passed to the '.
    'listener.');
} else {
  $err_str = 
    'Error handler was reentered, some errors were not passed to the '.
    'listener.';
}

error_log($err_str);
epriestley edited edge metadata.
epriestley added inline comments.
src/error/PhutilErrorHandler.php
423–425 ↗(On Diff #31901)

I don't think we should translate this, because of the potential to recurse indefinitely if the error is in pht() itself.

That seems worse/more dangerous than a Spanish developer getting one English error message after already hitting a double-bad error.

This revision is now accepted and ready to land.Jun 8 2015, 8:56 PM
joshuaspence edited edge metadata.

Remove changes to PhutilErrorHandler

This revision was automatically updated to reflect the committed changes.