Page MenuHomePhabricator
Differential D13194

Convert Macro to SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 7 2015, 7:33 PM.
Tags
None
Referenced Files
F19149441: D13194.diff
Wed, Dec 10, 7:51 PM
F19079558: D13194.diff
Mon, Dec 1, 9:19 PM
F19059799: D13194.diff
Sat, Nov 29, 6:51 AM
F18853846: D13194.id.diff
Oct 31 2025, 8:00 PM
F18844805: D13194.diff
Oct 29 2025, 7:43 AM
F18784993: D13194.id31934.diff
Oct 13 2025, 4:39 PM
F18744384: D13194.id31884.diff
Oct 3 2025, 2:45 AM
F18720936: D13194.id.diff
Sep 29 2025, 7:57 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rP1de0ba58c146: Convert Macro to SearchFields
Summary

Ref T8441. Ref T7715. I'm primarily clearing callers to saveQueryOrder() so I can get rid of it.

Test Plan

Used all Macro search features.

Diff Detail

Repository
rP Phabricator
Branch
spaces8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6608
Build 6630: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31884.Jun 7 2015, 7:33 PM
epriestley retitled this revision from to Convert Macro to SearchFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2015, 7:33 PM
btrahan accepted this revision.Jun 8 2015, 6:39 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 6:39 PM
Closed by commit rP1de0ba58c146: Convert Macro to SearchFields (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
query/
43 lines
161 lines
search/
field/
8 lines

Diff 31884

View Options

src/applications/macro/query/PhabricatorMacroQuery.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchSelectField.php

Loading...
Phabricator · Built by Phacility