Page MenuHomePhabricator
Differential D13175

Convert Files to SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 5 2015, 10:40 PM.
Tags
None
Referenced Files
F21432883: D13175.diff
Thu, Jul 30, 4:22 AM
Unknown Object (File)
Jun 22 2026, 2:13 AM
Unknown Object (File)
Jun 21 2026, 7:58 PM
Unknown Object (File)
Jun 3 2026, 12:30 PM
Unknown Object (File)
Jun 2 2026, 3:22 PM
Unknown Object (File)
Apr 19 2026, 10:50 PM
Unknown Object (File)
Mar 9 2026, 7:06 PM
Unknown Object (File)
Mar 5 2026, 11:47 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rPcdef3e8bc868: Convert Files to SearchFields
Summary

Ref T8441. Ref T7715.

  • Update FileSearchEngine.
  • Nothing too special/fancy.
Test Plan
  • Searched for various files.

Diff Detail

Repository
rP Phabricator
Branch
spaces2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6581
Build 6603: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31851.Jun 5 2015, 10:40 PM
epriestley retitled this revision from to Convert Files to SearchFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 5 2015, 10:40 PM
btrahan accepted this revision.Jun 6 2015, 7:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2015, 7:58 PM
Closed by commit rPcdef3e8bc868: Convert Files to SearchFields (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2015, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
files/
query/
61 lines
86 lines
search/
field/
48 lines

Diff 31851

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchThreeStateField.php

Loading...
Phabricator · Built by Phacility