Move some value massaging into SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 5 2015, 4:24 PM.

Details

Reviewers

Maniphest Tasks

T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch

Commits

Restricted Diffusion Commit
rP65b891b09590: Move some value massaging into SearchFields

Summary

Ref T8441. Ref T7715. Let SearchFields do some value massaging before buiding queries so we don't have to work as hard in each SearchEngine. Particularly, they can handle evaluateTokens() from Tokenizers.

Test Plan

Paste automatically gained access to viewer(), etc.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31831.Jun 5 2015, 4:24 PM

epriestley retitled this revision from to Move some value massaging into SearchFields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 5 2015, 4:24 PM

epriestley added inline comments.Jun 5 2015, 4:25 PM

src/applications/paste/query/PhabricatorPasteSearchEngine.php
18–32	It still feels a little weak that we have to specify this and can't just infer the mapping from the fields, but I think it's pretty reasonable and don't see a way around it without some junk that involves `$query->$method($value)`, which I don't want to get involved with.