Differential D13167

Use a class constant instead of a hardcoded string
ClosedPublic
Actions

Authored by erik.fercak on Jun 5 2015, 2:19 PM.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP5deaeec6688a: Use a class constant instead of a hardcoded string

Required Signatures

L28 Phacility Individual Contributor License Agreement

Test Plan

Submitted a form - saw nothing out of ordinary.

Diff Detail

Repository

rP Phabricator

Branch

use_class_constant

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6569
Build 6591: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

erik.fercak updated this revision to Diff 31826.Jun 5 2015, 2:19 PM

erik.fercak retitled this revision from to Use a class constant instead of a hardcoded string.

erik.fercak updated this object.

erik.fercak edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 5 2015, 2:19 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

Can you sign L28? We require a CLA to review or accept changes.

Ah, thanks!

Closed by commit rP5deaeec6688a: Use a class constant instead of a hardcoded string (authored by erik.fercak, committed by epriestley). · Explain WhyJun 5 2015, 2:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

storage/

PhabricatorUser.php

3 lines

Diff 31826

View Options

src/applications/people/storage/PhabricatorUser.php

Use a class constant instead of a hardcoded stringClosedPublicActions