Page MenuHomePhabricator

Introduce a request cache mechanism
ClosedPublic

Authored by epriestley on Jun 4 2015, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 9:09 PM
Unknown Object (File)
Fri, Mar 22, 8:22 PM
Unknown Object (File)
Fri, Mar 22, 8:21 PM
Unknown Object (File)
Sun, Mar 17, 5:10 PM
Unknown Object (File)
Sat, Mar 16, 4:00 PM
Unknown Object (File)
Sat, Mar 16, 3:30 PM
Unknown Object (File)
Sat, Mar 16, 12:29 PM
Unknown Object (File)
Sun, Mar 10, 3:12 PM
Subscribers

Details

Summary

Ref T8424. This adds a standard KeyValueCache to serve as a request cache.

In particular, I need to cache Spaces (they are frequently accessed, sometimes by multiple viewers) but not have them survive longer than the scope of one request.

This request cache is explicitly destroyed by each web request and each daemon request.

In the very long term, building this kind of construct supports reusing PHP interpreters to run web requests (see some discussion in T2312).

Test Plan
  • Added and executed unit tests.
  • Ran every daemon.

Diff Detail

Repository
rP Phabricator
Branch
spaces3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6545
Build 6567: [Placeholder Plan] Wait for 30 Seconds