Paths

Table of Contentst

Tidy up ManiphestTask destruction
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 10:16 AM.

Tags

None

Referenced Files

	F14053716: D13110.diff
	Fri, Nov 15, 6:45 PM

	F14045470: D13110.id31656.diff
	Wed, Nov 13, 4:49 AM

	F14041465: D13110.diff
	Mon, Nov 11, 6:52 PM

	F14037378: D13110.id31650.diff
	Sun, Nov 10, 3:31 PM

	F14027146: D13110.diff
	Fri, Nov 8, 5:35 AM

	F14010355: D13110.diff
	Thu, Oct 31, 7:14 AM

	F14004644: D13110.diff
	Sun, Oct 27, 12:24 AM

	F13977419: D13110.id31650.diff
	Oct 18 2024, 6:30 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP2d15c3c06289: Tidy up ManiphestTask destruction

Summary

Now that ManiphestTask implements PhabricatorApplicationTransactionInterface, the transaction removal happens automatically.

Test Plan

Used ./bin/remove destroy to delete a ManiphestTask and saw related transactions removed as well.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31650.Jun 2 2015, 10:16 AM

joshuaspence retitled this revision from to Tidy up ManiphestTask destruction.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 10:16 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 2 2015, 11:59 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 2 2015, 11:59 AM

Closed by commit rP2d15c3c06289: Tidy up ManiphestTask destruction (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 2 2015, 12:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTask.php

12 lines

Diff 31656

View Options

src/applications/maniphest/storage/ManiphestTask.php

Tidy up ManiphestTask destructionClosedPublicActions