Paths

Table of Contentst

Tidy up ManiphestTask destruction
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 10:16 AM.

Tags

None

Referenced Files

	F15447834: D13110.id31650.diff
	Fri, Mar 28, 1:51 AM

	F15432769: D13110.id31650.diff
	Mon, Mar 24, 7:37 PM

	F15412221: D13110.id31650.diff
	Wed, Mar 19, 11:51 AM

	F15383194: D13110.id31650.diff
	Fri, Mar 14, 3:46 PM

	F15380123: D13110.diff
	Fri, Mar 14, 1:32 AM

	F15367489: D13110.diff
	Tue, Mar 11, 6:53 PM

	Unknown Object (File)
	Feb 17 2025, 6:19 PM

	Unknown Object (File)
	Feb 15 2025, 11:30 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP2d15c3c06289: Tidy up ManiphestTask destruction

Summary

Now that ManiphestTask implements PhabricatorApplicationTransactionInterface, the transaction removal happens automatically.

Test Plan

Used ./bin/remove destroy to delete a ManiphestTask and saw related transactions removed as well.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31650.Jun 2 2015, 10:16 AM

joshuaspence retitled this revision from to Tidy up ManiphestTask destruction.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 10:16 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 2 2015, 11:59 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 2 2015, 11:59 AM

Closed by commit rP2d15c3c06289: Tidy up ManiphestTask destruction (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 2 2015, 12:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTask.php

12 lines

Diff 31656

View Options

src/applications/maniphest/storage/ManiphestTask.php

Tidy up ManiphestTask destructionClosedPublicActions