Page MenuHomePhabricator
Differential D13102

Implement DestructibleInterface on Spaces, add some basic tests
ClosedPublic
Actions

Authored by epriestley on Jun 1 2015, 6:54 PM.
Tags
None
Referenced Files
F13143104: D13102.diff
Fri, May 3, 7:12 AM
F13139265: D13102.diff
Fri, May 3, 2:38 AM
Unknown Object (File)
Mon, Apr 29, 2:11 PM
Unknown Object (File)
Wed, Apr 24, 10:15 PM
Unknown Object (File)
Mon, Apr 22, 11:26 AM
Unknown Object (File)
Thu, Apr 11, 10:54 AM
Unknown Object (File)
Apr 1 2024, 10:40 AM
Unknown Object (File)
Mar 31 2024, 8:20 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8377: Build the core "Spaces" Application
Commits
Restricted Diffusion Commit
rP76523eec6718: Implement DestructibleInterface on Spaces, add some basic tests
Summary

Ref T8377. Mostly just a framework for test coverage.

Test Plan

Tests pass.

Diff Detail

Repository
rP Phabricator
Branch
spaces2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6430
Build 6452: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31631.Jun 1 2015, 6:54 PM
epriestley retitled this revision from to Implement DestructibleInterface on Spaces, add some basic tests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8377: Build the core "Spaces" Application.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 1 2015, 6:54 PM
btrahan accepted this revision.Jun 1 2015, 6:55 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/spaces/__tests__/PhabricatorSpacesTestCase.php
95–96

policy transactions not ready yet? or maybe this is necessary to make sure tests always work regardess of app settings?

This revision is now accepted and ready to land.Jun 1 2015, 6:55 PM
epriestley added inline comments.Jun 1 2015, 7:00 PM
src/applications/spaces/__tests__/PhabricatorSpacesTestCase.php
95–96

Oh, right. I added these for the latter case while doing something else but should be able to just use transactions.

epriestley updated this revision to Diff 31632.Jun 1 2015, 7:02 PM
epriestley edited edge metadata.
  • Use policy transactions.
Closed by commit rP76523eec6718: Implement DestructibleInterface on Spaces, add some basic tests (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2015, 7:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
applications/
spaces/
__tests__/
127 lines
storage/
12 lines
transactions/
editor/
7 lines

Diff 31631

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/spaces/__tests__/PhabricatorSpacesTestCase.php

Loading...
View Options

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility