Page MenuHomePhabricator
Differential D13098

Add 'colors' and 'icons' fields to conduit api for Projects
ClosedPublic
Actions

Authored by 20after4 on Jun 1 2015, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 11, 9:19 PM
Unknown Object (File)
Mon, Feb 3, 2:46 AM
Unknown Object (File)
Fri, Jan 31, 12:30 AM
Unknown Object (File)
Sun, Jan 26, 7:11 AM
Unknown Object (File)
Jan 9 2025, 2:19 AM
Unknown Object (File)
Jan 6 2025, 1:33 AM
Unknown Object (File)
Dec 29 2024, 5:11 PM
Unknown Object (File)
Dec 16 2024, 2:46 PM
View All Files
Subscribers
aklapper
epriestley
Korvin
legoktm
qgil
valhallasw

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPdfac9d7f520f: Add 'colors' and 'icons' fields to conduit api for Projects
Summary

This simply adds colors, icons to ProjectQueryConduitAPIMethod and
ProjectCreateConduitAPIMethod.

Additionally, adds 'tags' to ProjectCreateConduitAPIMethod

Change-Id: Ic6332fe174a59ecfd60cea281ccb0ed938136141

Test Plan

create a new project with project.create, specify icon, color and tags

call project.query with colors and icons args, check for results
containing matching projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

20after4 updated this revision to Diff 31622.Jun 1 2015, 4:04 PM
20after4 retitled this revision from to Add 'colors' and 'icons' fields to conduit api for Projects.
20after4 updated this object.
20after4 edited the test plan for this revision. (Show Details)
20after4 added a reviewer: epriestley.
20after4 added subscribers: qgil, valhallasw.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 1 2015, 4:04 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
20after4 updated this revision to Diff 31623.Jun 1 2015, 4:24 PM
20after4 edited edge metadata.

prepend fa- to the icons values
fix typo

epriestley requested changes to this revision.Jun 1 2015, 5:06 PM
epriestley edited edge metadata.

These changes are fine, but I want to hold expansions of these APIs until T5873 (for transactions) and T7715 (for queries).

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php
19

No apparent effect?

This revision now requires changes to proceed.Jun 1 2015, 5:06 PM
20after4 updated this revision to Diff 31686.Jun 2 2015, 8:01 PM
20after4 edited edge metadata.

include the changes to tags that should have been in the last diff.

20after4 marked an inline comment as done.Jun 2 2015, 8:03 PM

Ok not sure how I missed that last bit...

aklapper added a subscriber: aklapper.Jun 3 2015, 6:33 PM
legoktm added a subscriber: legoktm.Jun 3 2015, 6:36 PM
epriestley added a comment.Jun 3 2015, 6:43 PM

(If this is blocking a bunch of cool/important stuff I don't mind looking the other way and landing it, we just end up in a bad place on average by limping along like this.)

epriestley accepted this revision.Jun 3 2015, 6:43 PM
epriestley edited edge metadata.

whoops what happened

This revision is now accepted and ready to land.Jun 3 2015, 6:43 PM
Closed by commit rPdfac9d7f520f: Add 'colors' and 'icons' fields to conduit api for Projects (authored by 20after4, committed by epriestley). · Explain WhyJun 3 2015, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
conduit/
21 lines
18 lines

Diff 31742

View Options

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

Loading...
View Options

src/applications/project/conduit/ProjectQueryConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility