Page MenuHomePhabricator

Prevent an error when the Drydock lease artifact does not exist
ClosedPublic

Authored by hach-que on May 30 2015, 12:38 PM.
Tags
None
Referenced Files
F14065068: D13074.diff
Tue, Nov 19, 2:53 AM
F14051187: D13074.diff
Thu, Nov 14, 10:52 PM
F14038675: D13074.diff
Mon, Nov 11, 1:16 AM
F14024727: D13074.diff
Thu, Nov 7, 11:49 AM
F14015739: D13074.id31561.diff
Sun, Nov 3, 11:48 PM
F14009556: D13074.id.diff
Wed, Oct 30, 7:56 PM
Unknown Object (File)
Oct 10 2024, 10:14 AM
Unknown Object (File)
Oct 2 2024, 1:14 PM

Details

Summary

If a host artifact exists in a Harbormaster build, where the Drydock lease no longer exists, then an error will be raised because of the attempt to access an undefined index. This changes the code to use idx() so that it correctly returns null instead.

Test Plan

Tested in production.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hach-que retitled this revision from to Prevent an error when the Drydock lease artifact does not exist.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 31 2015, 2:29 PM
This revision was automatically updated to reflect the committed changes.