Paths

Table of Contentst

Differential D13067

Fix reverting commit language
ClosedPublic
Actions

Authored by joshuaspence on May 29 2015, 12:15 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPebde9357c7f8: Fix reverting commit language

Summary

I think the language here is inverted? On a commit which is reverted, the text states $author added a reverted commit: $commit. In reality, $commit is the reverting commit, not the reverted commit.

Test Plan

Think about English.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31528.May 29 2015, 12:15 PM

joshuaspence retitled this revision from to Fix reverting commit language.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2015, 12:15 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 31 2015, 2:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 31 2015, 2:29 PM

Closed by commit rPebde9357c7f8: Fix reverting commit language (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 31 2015, 11:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

edge/

DiffusionCommitRevertedByCommitEdgeType.php

12 lines

DiffusionCommitRevertsCommitEdgeType.php

12 lines

Diff 31581

View Options

src/applications/diffusion/edge/DiffusionCommitRevertedByCommitEdgeType.php