Page MenuHomePhabricator
Differential D13060

Remarkup - add a quote button
ClosedPublic
Actions

Authored by btrahan on May 28 2015, 10:25 PM.

Details

Reviewers
epriestley
Maniphest Tasks
T7696: Add a button on comment/description editor interface for quote blocks
Commits
Restricted Diffusion Commit
rPb2d003d025ca: Remarkup - add a quote button
Summary

Fixes T7696.

Test Plan

hit the quote button with no text - it worked. highlighted some text and hit the quote button - it worked. hit the list item button with no text - it worked. hit the list item button with text selected - it worked

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31509.May 28 2015, 10:25 PM
btrahan added a task: T7696: Add a button on comment/description editor interface for quote blocks.
btrahan retitled this revision from to Remarkup - add a quote button.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 28 2015, 10:25 PM
epriestley accepted this revision.May 28 2015, 10:27 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2015, 10:27 PM
Closed by commit rPb2d003d025ca: Remarkup - add a quote button (authored by btrahan, committed by btrahan). · Explain WhyMay 28 2015, 10:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
view/
form/
control/
4 lines
webroot/
rsrc/
js/
core/
25 lines

Diff 31511

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
Phabricator · Built by Phacility