Differential D13057

Conpherence - add tooltip for full time for messages
ClosedPublic
Actions

Authored by btrahan on May 28 2015, 9:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 3:36 AM

	Unknown Object (File)
	Tue, Apr 30, 6:37 PM

	Unknown Object (File)
	Mon, Apr 29, 3:32 PM

	Unknown Object (File)
	Wed, Apr 24, 11:32 PM

	Unknown Object (File)
	Thu, Apr 11, 7:56 AM

	Unknown Object (File)
	Tue, Apr 9, 6:06 AM

	Unknown Object (File)
	Mar 29 2024, 10:56 PM

	Unknown Object (File)
	Feb 11 2024, 5:32 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T8154: Conpherence threads don't specify the day they are created

Commits

Restricted Diffusion Commit
rPc61b5440e1ba: Conpherence - add tooltip for full time for messages

Summary

Fixes T8154. Now you can tell when a Conpherence was started by mousing over the date. I think this is sufficient.

This ends up cleaning up the code significantly; it used to inherit from some transaction view class and had built up lots of cludge over time. Much cleaner now.

Test Plan

moused over tooltips in both durable column and full conpherence and saw correct full dates. clicked on a timestamp in durable column and went to right place in full conpherence.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31505.May 28 2015, 9:31 PM

btrahan added a task: T8154: Conpherence threads don't specify the day they are created.

btrahan retitled this revision from to Conpherence - add tooltip for full time for messages.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 28 2015, 9:31 PM

epriestley accepted this revision.May 28 2015, 10:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 28 2015, 10:18 PM

Closed by commit rPc61b5440e1ba: Conpherence - add tooltip for full time for messages (authored by btrahan, committed by btrahan). · Explain WhyMay 28 2015, 10:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

ConpherenceTransactionRenderer.php

18 lines

query/

ConpherenceThreadSearchEngine.php

4 lines

view/

ConpherenceTransactionView.php

119 lines

Diff 31510

src/applications/conpherence/ConpherenceTransactionRenderer.php

Loading...

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Loading...

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...