Page MenuHomePhabricator
Differential D13047

[Redesign] Normalize nav spacing
ClosedPublic
Actions

Authored by chad on May 28 2015, 3:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 1:50 PM
Unknown Object (File)
Sat, Dec 14, 4:50 PM
Unknown Object (File)
Fri, Dec 13, 8:40 PM
Unknown Object (File)
Sun, Dec 8, 2:00 AM
Unknown Object (File)
Thu, Dec 5, 4:39 AM
Unknown Object (File)
Thu, Nov 28, 4:15 PM
Unknown Object (File)
Mon, Nov 25, 7:51 PM
Unknown Object (File)
Mon, Nov 25, 8:46 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP7fa5e63f0d65: [Redesign] Normalize nav spacing
Summary

Ref T8099. Not sure if this was accidentally removed, but overflow: hidden saves the day once again. Fixes an issue where different pages had navs starting at different spots based on crumbs or object boxes.

Test Plan

Test Projects, People, Dashboards, lots of other navs. All start at 8px now.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 31477.May 28 2015, 3:41 AM
chad retitled this revision from to [Redesign] Normalize nav spacing.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 28 2015, 3:41 AM
epriestley accepted this revision.May 28 2015, 6:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2015, 6:11 PM
epriestley added a comment.May 28 2015, 6:12 PM

Oh, does this break tooltips on the home page?

chad added a comment.May 28 2015, 6:36 PM

I can't find any broken ones, offhand. Checked application tooltips like audit, object list icon tooltips.

epriestley added a comment.May 28 2015, 6:36 PM

√

Closed by commit rP7fa5e63f0d65: [Redesign] Normalize nav spacing (authored by chad, committed by chad). · Explain WhyMay 28 2015, 6:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
aphront/
5 lines

Diff 31496

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

Loading...
Phabricator · Built by Phacility