Differential D13013

Fix day view start hour
ClosedPublic
Actions

Authored by lpriestley on May 25 2015, 9:29 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8308: Fix broken day start hour in day view

Commits

Restricted Diffusion Commit
rP04bf04d783db: Fix day view start hour

Summary

Ref T8308, Fix day view start hour

Test Plan

Day views start at 8am OR hour of first event start time if there is an event scheduled before 8am on that day OR midnight if there is a non-all-day multi-day event carried over from the previous day

Diff Detail

Repository

rP Phabricator

Branch

calendardayfirsthour

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6274
Build 6296: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31380.May 25 2015, 9:29 PM

lpriestley retitled this revision from to Fix day view start hour.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8308: Fix broken day start hour in day view.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2015, 9:29 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 25 2015, 9:55 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 25 2015, 9:55 PM

Closed by commit rP04bf04d783db: Fix day view start hour (authored by lpriestley, committed by lpriestley). · Explain WhyMay 26 2015, 3:51 AM

This revision was automatically updated to reflect the committed changes.

lpriestley mentioned this in T8308: Fix broken day start hour in day view.May 26 2015, 4:58 PM

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

calendar/

PHUICalendarDayView.php

21 lines

Diff 31380

View Options

src/view/phui/calendar/PHUICalendarDayView.php

Fix day view start hourClosedPublicActions