Page MenuHomePhabricator

Clicking in day view should create new event
ClosedPublic

Authored by lpriestley on May 24 2015, 5:33 PM.

Details

Summary

Ref T8300, clicking in day view should create new event

Test Plan

Open day view, click in an empty slot, new event modal should open.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Clicking in day view should create new event.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
45–46

We might need an:

if (!$start->isValid()) {
  return new Aphront400Response();
}

...here.

For example, if you pass ?year=quack&month=platypus&day=orangejuice, I think $start->getEpoch() and $start->getDateTime() will return null, so we'll fatal a little later on.

This revision is now accepted and ready to land.May 24 2015, 5:42 PM
lpriestley marked an inline comment as done.
lpriestley edited edge metadata.

Preventing quackoclock start times

This revision was automatically updated to reflect the committed changes.