Ref T8300, clicking in day view should create new event
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8179: Clicking in the day view calendar should create a new event for that day
T8300: Day view should implement a a Javelin behavior - Commits
- Restricted Diffusion Commit
rP18fe6d58aeba: Clicking in day view should create new event
Open day view, click in an empty slot, new event modal should open.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarneweventjs
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 6235 Build 6257: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/calendar/controller/PhabricatorCalendarEventEditController.php | ||
|---|---|---|
| 45–46 | We might need an: if (!$start->isValid()) { return new Aphront400Response(); } ...here. For example, if you pass ?year=quack&month=platypus&day=orangejuice, I think $start->getEpoch() and $start->getDateTime() will return null, so we'll fatal a little later on. | |