[Redesign] Put all ApplicationSearch results in an ObjectBox
ClosedPublic
Actions

Authored by chad on May 24 2015, 2:41 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rP3d407732d623: [Redesign] Put all ApplicationSearch results in an ObjectBox

Summary

Ref T8099. In most cases we return either an ObjectList or AphrontTable, and can pretty up the UI in ApplicationSearch. There are a few edge cases, like PeopleUserLog, that can be cleanup up individually in the future, but look fine for now.
Also added 'setNotice' for AphrontTable for a few cases where we want to convey addtional information.

TODO: Seems we always pass a Pager Object, which tries to get displayed, I'll redesign that interaction in the future, probably by passing the Pager to the ObjectBox

Test Plan

Went throught most/all ApplicationSearch panels I could find, even edge cases look better.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 31310.May 24 2015, 2:41 PM

chad retitled this revision from to [Redesign] Put all ApplicationSearch results in an ObjectBox.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 24 2015, 2:41 PM

epriestley accepted this revision.May 24 2015, 2:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 24 2015, 2:45 PM

I'm curious what's the right "longterm" solution here. Right now ApplicationSearch Queries *usually* return a List or Table, but sometimes other content and sometimes they modified the Header before sending. DashboardEngine does something similar. Should we maybe have a Header at the Query level as optional get sent up to ApplicationSearch then modified there? Sort of like DashboardPanels?

I'd have to spend some time looking at it and collecting the edge cases. I'd guess that we maybe require them to return some SearchResultListView sort of thing, and that's basically a thin wrapper around a header + form + results + pager, most of which gets filled in by default in most cases.

Pulling the pager/header/etc out separately might be another approach, but I'd guess it's messier overall.

Closed by commit rP3d407732d623: [Redesign] Put all ApplicationSearch results in an ObjectBox (authored by chad, committed by chad). · Explain WhyMay 24 2015, 4:14 PM

This revision was automatically updated to reflect the committed changes.