Page MenuHomePhabricator

Rescheduling events by dragging them in day view
ClosedPublic

Authored by lpriestley on May 24 2015, 1:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 11:36 PM
Unknown Object (File)
Mon, Nov 25, 11:36 PM
Unknown Object (File)
Mon, Nov 25, 10:10 PM
Unknown Object (File)
Mon, Nov 25, 12:51 PM
Unknown Object (File)
Sun, Nov 24, 2:41 PM
Unknown Object (File)
Thu, Nov 21, 1:19 PM
Unknown Object (File)
Wed, Nov 20, 9:26 PM
Unknown Object (File)
Wed, Nov 20, 5:22 PM
Subscribers

Details

Summary

Ref T8300, Rescheduling events by dragging them in day view

Test Plan

Open day view, drag events, observe them reschedule.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Rescheduling events by dragging them in day view.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
epriestley edited edge metadata.

We should fix the z-index.css thing and the JX.log() calls. Not sure if the 960 thing is a real bug. Other stuff is pretty fluff.

src/applications/calendar/controller/PhabricatorCalendarEventDragController.php
8

Consider $viewer = $this->getViewer();.

36

id() isn't necessary here since you aren't calling methods on the object immediately.

39

As above.

src/view/phui/calendar/PHUICalendarDayView.php
110–113

Slightly simpler as if (!$this->events) { ... }

121

Indents are a little weird here? This block should go in one level, I think.

140

This is probably really, like:

960 + (60 * number of hours before 8 AM we're showing)

That is, we probably do layout wrong on days with an event at, say, 2AM?

148

Does jsTodayEvents still need to be an object property (instead of just a local variable)?

webroot/rsrc/css/phui/calendar/phui-calendar-day.css
48

We should move this to z-index.css and pick a more appropriate number (likely 2 or 3 or something around there).

webroot/rsrc/js/application/calendar/behavior-day-view.js
254

Stray JX.log().

268

Stray log.

297

We probably don't need this anymore since we're returning a reload response.

305

Stray debugging.

This revision now requires changes to proceed.May 24 2015, 1:27 AM
lpriestley edited edge metadata.
lpriestley marked 11 inline comments as done.

per feedback

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 24 2015, 2:45 AM
This revision was automatically updated to reflect the committed changes.