Ref T8300, Rescheduling events by dragging them in day view
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8300: Day view should implement a a Javelin behavior
- Commits
- Restricted Diffusion Commit
rP963485a3da25: Rescheduling events by dragging them in day view
Open day view, drag events, observe them reschedule.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
We should fix the z-index.css thing and the JX.log() calls. Not sure if the 960 thing is a real bug. Other stuff is pretty fluff.
| src/applications/calendar/controller/PhabricatorCalendarEventDragController.php | ||
|---|---|---|
| 8 | Consider $viewer = $this->getViewer();. | |
| 36 | id() isn't necessary here since you aren't calling methods on the object immediately. | |
| 39 | As above. | |
| src/view/phui/calendar/PHUICalendarDayView.php | ||
| 110–113 | Slightly simpler as if (!$this->events) { ... } | |
| 121 | Indents are a little weird here? This block should go in one level, I think. | |
| 140 | This is probably really, like: 960 + (60 * number of hours before 8 AM we're showing) That is, we probably do layout wrong on days with an event at, say, 2AM? | |
| 148 | Does jsTodayEvents still need to be an object property (instead of just a local variable)? | |
| webroot/rsrc/css/phui/calendar/phui-calendar-day.css | ||
| 48 | We should move this to z-index.css and pick a more appropriate number (likely 2 or 3 or something around there). | |
| webroot/rsrc/js/application/calendar/behavior-day-view.js | ||
| 254 | Stray JX.log(). | |
| 268 | Stray log. | |
| 297 | We probably don't need this anymore since we're returning a reload response. | |
| 305 | Stray debugging. | |