Differential D12941

Add a YAML parser
AbandonedPublic
Actions

Authored by joshuaspence on May 19 2015, 10:35 PM.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Summary

WIP

Test Plan

WIP

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:10	XHP34	Comment Spaces
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:234	XHP34	Comment Spaces
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:238	XHP34	Comment Spaces
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:242	XHP34	Comment Spaces
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:243	XHP34	Comment Spaces
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:346	XHP34	Comment Spaces
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:393	XHP34	Comment Spaces
Error	src/parser/__tests__/PhutilYAMLParserTestCase.php:394	XHP34	Comment Spaces
Error	src/utils/utils.php:1074	XHP45	PHP Compatibility
Error	src/utils/utils.php:1074	XHP45	PHP Compatibility
Warning	src/parser/__tests__/PhutilYAMLParserTestCase.php:58	XHP27	Space Around Binary Operator
Warning	src/parser/__tests__/PhutilYAMLParserTestCase.php:244	TXT3	Line Too Long
Warning	src/parser/__tests__/PhutilYAMLParserTestCase.php:336	TXT3	Line Too Long
Warning	src/parser/__tests__/PhutilYAMLParserTestCase.php:377	TXT3	Line Too Long

Unit

Test Failures

Build Status

Buildable 6176
Build 6197: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	PhutilUtilsTestCase::testPhutilYAMLDecode
	0 ms	PhutilYAMLParserTestCase::testInvalidYAML
	0 ms	AbstractDirectedGraphTestCase::testBestEffortTopographicSortTree
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph
	0 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure
		View Full Test Results (2 Failed · 98 Passed)

Event Timeline

joshuaspence updated this revision to Diff 31160.May 19 2015, 10:35 PM

joshuaspence retitled this revision from to Add a YAML parser.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2015, 10:35 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Fix some tests

Unfortunately, this doesn't give nice error messages. My originally idea was to use this to write a YAML parser, but this won't work unless the YAML parser provides a line/character number for the syntax error.