Page MenuHomePhabricator

[Redesign] Remove PHUIActionHeaderView
ClosedPublic

Authored by chad on May 18 2015, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 5:44 PM
Unknown Object (File)
Sun, Mar 24, 10:24 AM
Unknown Object (File)
Tue, Mar 5, 10:43 AM
Unknown Object (File)
Tue, Mar 5, 10:43 AM
Unknown Object (File)
Tue, Mar 5, 10:43 AM
Unknown Object (File)
Feb 7 2024, 9:56 AM
Unknown Object (File)
Feb 3 2024, 4:00 AM
Unknown Object (File)
Jan 24 2024, 10:28 AM
Subscribers

Details

Summary

This adds minor functionality to PHUIHeaderView (icons, tags) that were previously on in ActionHeader. This allows us to remove the PHUIActionHeaderView outright in favor of just one Header class.

Test Plan

Tested each callsite, workboards, hovercards, conpherence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to [Redesign] Remove PHUIActionHeaderView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
src/applications/conpherence/controller/ConpherenceWidgetController.php
71–86

This section doesn't work, the JS fails and I'm not adept here enough to know what I need to tweak. The JS that fails is:

var widget_header = JX.DOM.find(widget_pane, 'a', 'widgets-selector');
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/controller/ConpherenceWidgetController.php
71–86

Maybe just leave a comment and we can clean it up later before merging?

Offhand, it might just be widgets-selector vs widgets_selector (hyphen vs underscore), as written.

This revision is now accepted and ready to land.May 18 2015, 4:20 PM
chad marked an inline comment as done.May 18 2015, 4:43 PM
chad added inline comments.
src/applications/conpherence/controller/ConpherenceWidgetController.php
71–86

68GK-1.png (267×334 px, 8 KB)

chad marked an inline comment as done.
chad edited edge metadata.
  • Fix Sigil, align headers, test widgets
This revision was automatically updated to reflect the committed changes.