Page MenuHomePhabricator

Rename XHPAST build script
ClosedPublic

Authored by joshuaspence on May 17 2015, 9:58 PM.
Tags
None
Referenced Files
F12806599: D12889.id31169.diff
Wed, Mar 27, 6:27 PM
Unknown Object (File)
Wed, Mar 27, 10:02 AM
Unknown Object (File)
Fri, Mar 1, 6:59 PM
Unknown Object (File)
Feb 10 2024, 9:49 PM
Unknown Object (File)
Feb 10 2024, 9:46 PM
Unknown Object (File)
Feb 6 2024, 7:01 PM
Unknown Object (File)
Jan 27 2024, 8:44 AM
Unknown Object (File)
Jan 7 2024, 2:08 PM
Subscribers

Details

Summary

Historically XHPAST was built using a shell script, but it is now executed by PHP. We should eventually rename this file for consistency. To retain compatibility, we could possibly symlink build_xhpast.sh to build_xhpast.php and then check the value of $argv[0] and emit a deprecation warning if build_xhpast.sh was called.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Rename XHPAST build script.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Nevermind, we want to keep the shebang

epriestley edited edge metadata.

PhutilXHPASTBinary.php still has the old path, I think?

This revision now requires changes to proceed.May 19 2015, 1:57 PM
joshuaspence edited edge metadata.

Update help text

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 11:39 PM
This revision was automatically updated to reflect the committed changes.