Tags

None

Referenced Files

	F14144092: D12889.id31169.diff
	Tue, Dec 3, 6:39 PM

	Unknown Object (File)
	Thu, Nov 28, 9:15 AM

	Unknown Object (File)
	Thu, Nov 28, 2:19 AM

	Unknown Object (File)
	Fri, Nov 22, 9:47 AM

	Unknown Object (File)
	Wed, Nov 20, 6:23 PM

	Unknown Object (File)
	Mon, Nov 18, 11:54 PM

	Unknown Object (File)
	Mon, Nov 18, 5:10 AM

	Unknown Object (File)
	Oct 21 2024, 4:09 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUcf22ba3c303e: Rename XHPAST build script

Summary

Historically XHPAST was built using a shell script, but it is now executed by PHP. We should eventually rename this file for consistency. To retain compatibility, we could possibly symlink build_xhpast.sh to build_xhpast.php and then check the value of $argv[0] and emit a deprecation warning if build_xhpast.sh was called.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30994.May 17 2015, 9:58 PM

joshuaspence retitled this revision from to Rename XHPAST build script.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2015, 9:58 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Remove shebang

Nevermind, we want to keep the shebang

PhutilXHPASTBinary.php still has the old path, I think?

This revision now requires changes to proceed.May 19 2015, 1:57 PM

Update help text

epriestley accepted this revision.May 19 2015, 11:39 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 11:39 PM

Closed by commit rPHUcf22ba3c303e: Rename XHPAST build script (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:43 PM

This revision was automatically updated to reflect the committed changes.

Rename XHPAST build script
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31169

scripts/build_xhpast.php

scripts/build_xhpast.sh

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Rename XHPAST build scriptClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31169

scripts/build_xhpast.php

scripts/build_xhpast.sh

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Rename XHPAST build script
ClosedPublic
Actions

Revision Contents
Changeset List