Page MenuHomePhabricator
Differential D12887

Month view header should display month name of the month completely shown, not leading or trailing month.
ClosedPublic
Actions

Authored by lpriestley on May 17 2015, 8:41 PM.
Tags
None
Referenced Files
F13215973: D12887.diff
Fri, May 17, 9:31 PM
F13205289: D12887.diff
Wed, May 15, 1:47 AM
F13188682: D12887.diff
Sat, May 11, 5:24 AM
Unknown Object (File)
Tue, May 7, 8:41 AM
Unknown Object (File)
Fri, May 3, 8:46 AM
Unknown Object (File)
Thu, Apr 25, 2:36 AM
Unknown Object (File)
Apr 1 2024, 5:56 PM
Unknown Object (File)
Mar 20 2024, 7:19 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8229: Calendar month view header should show the name of the full month shown, not the month that the first displayed dates start on.
Commits
Restricted Diffusion Commit
rPa527d6c340d0: Month view header should display month name of the month completely shown…
Summary

Fixes T8229, Month view header should display month name of the month completely shown, not leading or trailing month.

Test Plan

Open month view for May. Month view header should be May, not April.

Diff Detail

Repository
rP Phabricator
Branch
calendarmonthheader
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6043
Build 6063: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30987.May 17 2015, 8:41 PM
lpriestley retitled this revision from to Month view header should display month name of the month completely shown, not leading or trailing month..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8229: Calendar month view header should show the name of the full month shown, not the month that the first displayed dates start on. .
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2015, 8:41 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 17 2015, 11:00 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 11:00 PM
Closed by commit rPa527d6c340d0: Month view header should display month name of the month completely shown… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 17 2015, 11:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
calendar/
11 lines

Diff 30987

View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
Phabricator · Built by Phacility