Phame - move over post creation and edit to use an editor
ClosedPublic
Actions

Authored by btrahan on May 15 2015, 7:36 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7626: Attaching files to a Phame post doesn't mark them as public

Commits

Restricted Diffusion Commit
rPb6733e4a8643: Phame - move over post creation and edit to use an editor

Summary

This adds the bare minimum transaction set for editing posts. Fixes T7626 because now files will be correctly attached to phame posts on subsequent edits. Future work here should be adding transaction types like TYPE_BLOG for when posts are moved between blogs, TYPE_VISIBILITY for when posts are moved to published, etc. Nothing too tricky there but keeping this diff relatively small seems prudent.

Test Plan

made posts successfully. also made errors like no title, no phame title, and duplicate phame title and got correct errors. added a file to a post and verified file has phame post in "attached" tab, which should fix T7626.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 30943.May 15 2015, 7:36 PM

btrahan retitled this revision from to Phame - move over post creation and edit to use an editor.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T7626: Attaching files to a Phame post doesn't mark them as public.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 15 2015, 7:36 PM

btrahan added inline comments.May 15 2015, 7:39 PM

src/applications/phame/editor/PhameBlogEditor.php
79–80	I had thought I want Comment transactions when I was doing the blog version of this and noticed I left them in there while doing this work. basically unrelated cleanup.